You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
The script replaces SE_SESSIONS_HOST/PORT with SE_SESSIONS_MAP_HOST/PORT. Verify that all dependent components and configurations are updated accordingly to use the new variable names.
Add validation to ensure the port number is within valid range (1-65535) before using it in PORT_CONFIG to prevent potential network configuration issues.
if [ ! -z "${SE_SESSIONS_MAP_PORT}" ]; then
- echo "Using SE_SESSIONS_MAP_PORT: ${SE_SESSIONS_MAP_PORT}"- PORT_CONFIG="--port ${SE_SESSIONS_MAP_PORT}"+ if [[ "${SE_SESSIONS_MAP_PORT}" =~ ^[0-9]+$ ]] && [ "${SE_SESSIONS_MAP_PORT}" -ge 1 ] && [ "${SE_SESSIONS_MAP_PORT}" -le 65535 ]; then+ echo "Using SE_SESSIONS_MAP_PORT: ${SE_SESSIONS_MAP_PORT}"+ PORT_CONFIG="--port ${SE_SESSIONS_MAP_PORT}"+ else+ echo "Error: SE_SESSIONS_MAP_PORT must be a number between 1 and 65535"+ exit 1+ fi
fi
Apply this suggestion
Suggestion importance[1-10]: 8
__
Why: The suggestion adds crucial input validation for port numbers, preventing potential network configuration issues and system failures. This is an important security and reliability improvement.
The action failed because the GitHub authentication token lacks the required 'read:org' scope permission. The error occurred during the gh auth login command, which requires proper token permissions to authenticate with GitHub CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Documentation
Description
Updated environment variables for default ports across components.
Replaced
SE_SESSIONS_HOSTandSE_SESSIONS_PORTwithSE_SESSIONS_MAP_HOSTandSE_SESSIONS_MAP_PORT.Added default port values for several components in Dockerfiles and documentation.
Simplified
docker-composefiles by removing redundant environment variables.Changes walkthrough 📝
1 files
Replace `SE_SESSIONS_HOST` and `SE_SESSIONS_PORT` with new variables15 files
Add default port environment variables for DistributorAdd default port environment variables for EventBusAdd default port environment variable for HubAdd default port environment variables for RouterAdd default port environment variable for SessionQueueAdd default port environment variables for SessionsUpdate environment variables for session map deploymentSimplify environment variables for development compose fileSimplify environment variables for external datastore compose fileSimplify environment variables for nightly compose fileSimplify environment variables for secure compose fileSimplify environment variables for tracing compose fileSimplify environment variables for default compose fileRemove deprecated session environment variablesAdd default values for new environment variables1 files
Document default port values for environment variables